Fix completion with enter key #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adapter will try to complete at each keyup event. However, it shouldn't try to complete when the enter key is pressed (either because the enter key can be used to select a previous completion, or to insert a line break).
When the enter key is pressed, the dropdown should be closed.
|
Hi @tleruitte, thanks for the patch. It looks good to me. I'll bump the version 👍 |
yuku
added
the
DEPRECATED jquery-textcomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin is working great when the completion is done with the mouse (i.e. clicking on a suggestion with the mouse), but is buggy when a suggestion is chosen with the enter key.