Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUAD] Enhancement: Enforce thumbnail for Houdini publish #6335

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ccaillot
Copy link

No description provided.


# Use the first image as a thumbnail if it's not already set.
if not instance.data.get("thumbnailSource") and output:
instance.data["thumbnailSource"] = os.path.join(staging_dir, output[0])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (83 > 79 characters)

@ynbot ynbot added host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Sep 11, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Sep 11, 2024

Interesting approach :) But I think it's not the way for AYON. Preferably we define which are reviewables and from reviewable representations a thumbnail may be taken if it's not defined yet and I believe it does that already in AYON too.

@iLLiCiTiT @MustafaJafar thoughts?

@MustafaJafar
Copy link
Contributor

Interesting approach :) But I think it's not the way for AYON. Preferably we define which are reviewables and from reviewable representations a thumbnail may be taken if it's not defined yet and I believe it does that already in AYON too.

@iLLiCiTiT @MustafaJafar thoughts?

In my opinion, I think it'd be much better to have that for all product types.
I can think of the following approach:

Thumbnail: 
1. Artists can use the publisher to capture a thumbnail.
2. If no thumbnail and `create_thumbnail == true`
  a. For products with a review representation: get the first frame of the representation.
  b. For render products: get the first frame. *we may convert it to a different extension first.*
  c. Fall to the default: Take a screengrab of the scene view.

I think this can be implemented in ExtractActiveViewThumbnail plugin and we can provide some settings to allow admins to control how the plugin should work.
It's also worth mentioning that we already create thumbnails for workfile instance. and we can re-use it with other product types.

Maybe we can create an issue on ayon-houdini and link to this PR for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

4 participants