Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a backend developer, I want custom user-agent so I can understand what version of IDE accesses API #1696

Open
1 task
knopki opened this issue Feb 22, 2019 · 0 comments

Comments

@knopki
Copy link
Member

knopki commented Feb 22, 2019

Rationale

We have standard electron's user-agent like this:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) BeakerBrowser/0.8.5 Chrome/69.0.3497.106 Electron/4.0.4 Safari/537.36

in xod-client-electron and standard browser's user-agent in xod-client-browser. So, in our APIs we can identify type of the client: electron or web.

I propose to append XOD/${version} to the User-Ahent in xod-client-electron, so we also can identify which version of the client is used. We can change the behavior of our APIs for client version or drop legacy feature which is not in use.

Acceptance criteria

  • The User-Agent header has the IDE version in it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant