Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools): merge mountpoint into client package #4920

Merged
merged 6 commits into from
Nov 6, 2023
Merged

feat(devtools): merge mountpoint into client package #4920

merged 6 commits into from
Nov 6, 2023

Conversation

Asuka109
Copy link
Collaborator

@Asuka109 Asuka109 commented Nov 6, 2023

Summary

🤖 Generated by Copilot at 5e78e55

This pull request enhances the DevTools client package with TypeScript, ESLint, Radix UI, and dynamic mounting features. It updates the ESLint configuration, the Modern.js app configuration, and the package.json file. It also renames and moves some files to the client subfolder, and adds a new mount.mjs file that exports a function to inject the DevTools UI into any web page.

Details

🤖 Generated by Copilot at 5e78e55

  • Add a function mountDevTools to dynamically inject the DevTools UI into any web page (link)
  • Add a type annotation for the ESLint configuration object and disable the curly rule (link, link)
  • Update the Modern.js app configuration to use TypeScript, change the entry points, and add a custom bundler chain (link, link, link)
  • Update the package.json file of the DevTools client package to specify the entry points for the package (link)
  • Rename the radix-token-transformer.js file and move it to the plugins folder (link)
  • Rename and move the files in the src/components folder to the src/client/components folder (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 68737eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Asuka109
Copy link
Collaborator Author

Asuka109 commented Nov 6, 2023

!canary

@Asuka109
Copy link
Collaborator Author

Asuka109 commented Nov 6, 2023

!canary

@Asuka109 Asuka109 merged commit 2803118 into web-infra-dev:main Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants