Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo await when run getAvailableVersion #4860

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix: typo await when run getAvailableVersion #4860

merged 2 commits into from
Oct 25, 2023

Conversation

caohuilin
Copy link
Member

@caohuilin caohuilin commented Oct 25, 2023

Summary

🤖 Generated by Copilot at 2c6c821

Fixed a bug in getModernPluginVersion by awaiting getAvailableVersion in packages/generator/generator-utils/src/index.ts. This ensures that the correct plugin version is returned for each package.

Details

🤖 Generated by Copilot at 2c6c821

  • Fix bug in getModernPluginVersion function by awaiting getAvailableVersion promise (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: 649f5a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JSerFeng
JSerFeng previously approved these changes Oct 25, 2023
@caohuilin caohuilin enabled auto-merge (squash) October 25, 2023 10:18
@caohuilin caohuilin merged commit 5699cc9 into main Oct 25, 2023
7 checks passed
@caohuilin caohuilin deleted the fix-typo branch October 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants