-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the issue when set more than two cookie #4444
Conversation
🦋 Changeset detectedLatest commit: 6b17028 The changes in this PR will be included in the next version bump. This PR includes changesets to release 263 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4444 +/- ##
==========================================
- Coverage 57.59% 50.98% -6.62%
==========================================
Files 672 665 -7
Lines 17794 18273 +479
Branches 3876 4188 +312
==========================================
- Hits 10249 9317 -932
- Misses 6934 8266 +1332
- Partials 611 690 +79 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 6b17028
Fix and test the
setCookie
method of theBaseResponse
class in the@modern-js/prod-server
package. This method allows setting cookies in the response object using theresponse.cookies.set
method. The change also updates the changeset file for the patch release.Details
🤖 Generated by Copilot at 6b17028
setCookie
method ofBaseResponse
class that could cause problems when setting multiple cookies (link,link)@modern-js/prod-server
package (link)setCookie
method ofBaseResponse
class inhook.test.ts
file (link)Related Issue
Checklist
pnpm run change
.