Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): modify source-code-build test case about enable ts-loader #4282

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

targeral
Copy link
Member

@targeral targeral commented Jul 24, 2023

Summary

🤖 Generated by Copilot at 64f568d

Refactored the integration tests for the source code build to use a new common package that contains shared types and constants. Created the common package as a workspace and a dependency for the app-ts-loader package. Updated the TypeScript configurations and imports to enable project references and type checking. Removed unnecessary console logs and dependencies.

Details

🤖 Generated by Copilot at 64f568d

  • Refactor the app-ts-loader package to use the common package as a dependency and leverage its types and constants (link, link, link, link, link, link)
  • Create the common package as a workspace and a dependency for the app package, with its own package.json, tsconfig.json, readme.md, and src folder (link, link, link, link, link)
  • Replace the dependency @source-code-build/components by @source-code-build/common in the package.json of the app-ts-loader package (link)
  • Remove unnecessary console logs from the index.test.ts file in the tests/integration/source-code-build folder (link, link)
  • Add a tsconfig.json file in the tests/integration/source-code-build folder to configure the TypeScript project for the integration tests (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

⚠️ No Changeset found

Latest commit: 64f568d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.18 ⚠️

Comparison is base (99693f0) 57.59% compared to head (64f568d) 56.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4282      +/-   ##
==========================================
- Coverage   57.59%   56.42%   -1.18%     
==========================================
  Files         672      664       -8     
  Lines       17794    18084     +290     
  Branches     3876     3948      +72     
==========================================
- Hits        10249    10204      -45     
- Misses       6934     7219     +285     
- Partials      611      661      +50     

see 387 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenjiahan chenjiahan merged commit 240a8f8 into web-infra-dev:main Jul 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants