Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Ligatures + Prettify Symbols Mode? #239

Open
harrisj opened this issue Oct 1, 2021 · 42 comments
Open

Font Ligatures + Prettify Symbols Mode? #239

harrisj opened this issue Oct 1, 2021 · 42 comments
Labels
Feature requests Feature Requests

Comments

@harrisj
Copy link

harrisj commented Oct 1, 2021

Describe the solution you'd like?

This is obviously not urgent, but would it be possible to add a toggle to enable something like Emacs prettify-symbols mode for the terminal. This is a display mode that translates things like -> or != into Unicode characters for things like right arrow or the not-equals sign. Obviously, people might want to tweak this in different ways and it's a complicated feature, but it is pretty too!

Is your feature request related to a problem? Please describe.

No

Additional context

@gagata
Copy link

gagata commented Oct 20, 2021

Duplicate of #260

@gagata gagata marked this as a duplicate of #260 Oct 20, 2021
@gagata gagata closed this as completed Oct 20, 2021
@elviskahoro elviskahoro reopened this Nov 8, 2021
@elviskahoro elviskahoro changed the title Prettify Symbols Mode? Theming: Font Ligatures -> Prettify Symbols Mode? Nov 8, 2021
@elviskahoro elviskahoro changed the title Theming: Font Ligatures -> Prettify Symbols Mode? Font Ligatures + Prettify Symbols Mode? Dec 7, 2021
@fbartho
Copy link

fbartho commented Jan 13, 2022

I have a Monospace font that supports Ligatures Monoid HalfTight, and it is installed in my User's Font Book.
Screenshot of the Font Book displaying some ligatures rendered in Monoid HalfTight

This font is not selectable in the Font picker in Warp. It would be lovely if available fonts could be selected!

@emliunix
Copy link

emliunix commented Apr 6, 2022

Also, fonts may have ligation sets to choose from. eg. ss07, HSKL of Iosevka: https://typeof.net/Iosevka/

VSCode allows settings like: "editor.fontLigatures": "'ss07', 'HSKL'", in addition to true/false.
WezTerm allows settings like:

{
    family = "Iosevka Term",
    harfbuzz_features = {"calt=1", "clig=1", "liga=1", "ss07", "HSKL"},
}

@Amparose
Copy link

Amparose commented Jun 4, 2022

How is this not driving the devs mad. Assuming this is the reason n/vim looks like arse in Warp:

CleanShot 2022-06-04 at 14 25 23@2x

Top: Warp
Bottom: Kitty

Padding on RH in Warp is weird as well and messes up the bufferline.

I hope the devs making a modern terminal aren't full-time VSCode users...

@elviskahoro
Copy link
Contributor

No eta on ligatures.

@Amparose there are people on our team who use Vim. There are some vim improvements in the works. We're primarily tracking them in other issues thouugh.

@blakedietz
Copy link

I don't mean to beat a dead horse and be that guy that just says "want this", but this feature is table stakes for me and will be the reason why I continue to use iterm2 instead.

@diegoulloao
Copy link

I don't mean to beat a dead horse and be that guy that just says "want this", but this feature is table stakes for me and will be the reason why I continue to use iterm2 instead.

same here, in 2023 still waiting for those improvements...

@elviskahoro
Copy link
Contributor

@vorporeal will work on this eventually

@thezacharytaylor
Copy link

Any progress on this? Using things like Neovim and LazyGit is kinda awkward if you're used to ligature support.

@diegoulloao
Copy link

finally I decided to switched to iterm2 again 👀

@dannyneira
Copy link
Member

hey folks, this is on our radar, no promise on the eta, but we're aware of the request and trying to make it a reality 🤞

image

@carlosvigil
Copy link

Take your time, it's an awesome terminal.

@daUnknownCoder
Copy link

image

how's it going? its ~6 months

@clumsy
Copy link

clumsy commented Feb 3, 2024

I'm not sure how but Fira Code ligature font is now selectable for me and I was able to use it just fine. Thanks Warp team!

Screenshot 2024-02-03 at 4 19 20 PM

@zoedsoupe
Copy link

yeah, fira code works fine on the warp UI, but as soon as you try to use neovim or helix it stops to render ligatures. also so strange that only fira code is “supported”.

@clumsy
Copy link

clumsy commented Feb 4, 2024

Right @zoedsoupe , same with my helix and even echo output:
Screenshot 2024-02-03 at 8 17 27 PM
So it's just the terminal input that is working then (and the font being selectable).

@daUnknownCoder
Copy link

Only fira code works, and fonts patched with nerd symbols and icons and ligatures do not work either

@daUnknownCoder
Copy link

this is the whole thing:
2024-02-04-110328_hyprshot
2024-02-04-110322_hyprshot
2024-02-04-110239_hyprshot
left kitty, right warp ->
2024-02-04-105936_hyprshot

@EvanCarroll
Copy link

EvanCarroll commented Feb 22, 2024

Screenshot_2024-02-22_16-00-12

This whole project is stupid. Warp is calling their terminal "modern" and doesn't even support the fonts of the gods with ligatures. My terminal will never be closed source. If you want a Rust terminal use alacritty, or use Kitty like god intended. If those aren't modern enough for you, you get a one way ticket to a gulag in Cupertino, Siberia. Free Software #RideOrDie And seriously, who opens a project on GitHub for a closed-source product just to use the issue-tracker so their wanna-be fad-riding userbase can pretend like they're not squares using a corporately owned terminal. This marketing is straight up Oracle 2.0.

Respect yourself. Install Debian: apt install kitty.

@igorsantos07
Copy link

igorsantos07 commented Feb 23, 2024

Damn, that guy must be very angry with something in his own life.


Anyway, I should mention FiraCode wasn't selectable for me, but I can confirm that it shows ligatures only on input, and not all of them - e.g. != stayed that way, but === got joined together.

@EvanCarroll
Copy link

I'm not angry. I use Kitty and last night the light of heaven shown upon me so brightly I awoke from my slumber and came to spread the good word.

Hallowed is the Fira Code with Nerd font extensions and blessed are all those that use it. May their powerlevel10k forever inform them with font icons. May they forever use open source terminals lest their session be riddled with spyware that invades commercial closed source products. And may their not-equals always render as a single glyph without an exclamation point, which is always a mere punctuation mark as taught in grade school. Amen.

@adriangalilea
Copy link

Lovely terminal, but not supporting ligatures after so much time is odd.

@juanlopez4691
Copy link

Update after update and we still don't get properly working ligatures? Really? 😓

@sandikata
Copy link

It's a kind of joke, but however they're pushing a lot of emails with Description "How cool is warp terminal over anything else". I don't know what is cool in closed source, and missing features (available even in minimalistic solutions).

@juanlopez4691
Copy link

juanlopez4691 commented Apr 29, 2024

I waited long enough for this. I am back to good old Iterm2. Perhaps I will check Kitty, see how it behaves. Bye, Warp.

@igorsantos07
Copy link

Oh, the drama of the people that don't understand THEY'RE NOTIFYING EVERYONE about their drama.

Please, freaking stop commenting +1 or "omg I don't love warp anymore /cry". If you're a real tech-savvy person, you should know how GitHub works. People got subscribed to the issue not because they want to hear you bashing the tool, but because they want to get actual updates about the problem. The devs probably have other stuff to do than working on your precious little ligatures. If you're a senior developer, you definitely should know how prioritization on projects sometimes get odd.

If you're crying over a non-working feature, either thumb-up the issue or message support. Don't comment over and over and over again on the thread many people subscribed to.

@sandikata
Copy link

Oh, the drama of the people that don't understand THEY'RE NOTIFYING EVERYONE about their drama.

Please, freaking stop commenting +1 or "omg I don't love warp anymore /cry". If you're a real tech-savvy person, you should know how GitHub works. People got subscribed to the issue not because they want to hear you bashing the tool, but because they want to get actual updates about the problem. The devs probably have other stuff to do than working on your precious little ligatures. If you're a senior developer, you definitely should know how prioritization on projects sometimes get odd.

If you're crying over a non-working feature, either thumb-up the issue or message support. Don't comment over and over and over again on the thread many people subscribed to.

Who cares about your rage comment?

If a fully open source project with just one developer can support all the features without any tickets or so.
We don't like to be spammed like hell for something which we tried once to see it doesn't feet any needs, but they keep spam our emails with how great is this thing.

@adriangalilea
Copy link

adriangalilea commented Apr 29, 2024

@igorsantos07 I kind of agree with you, but this is the places for feature request they have enabled and is logically the place people both bump and complain about.

Also, just to expand your tech-savviness 😝 , customize the notifications on the issue and make it only notify you when it's closed.

@RodEsp
Copy link

RodEsp commented May 9, 2024

Please 🙏🏼
We need these everywhere, not just the terminal input.

image

@FradSer
Copy link

FradSer commented May 18, 2024

Please 🙏🏼

@gcstr
Copy link

gcstr commented Jun 18, 2024

Pretty please?

@degouville
Copy link

👀

@MichalCiechanowski
Copy link

ok, it has been 1346 days since this topic was open can someone tell me is there any effort being made in order to bring ligatures in to warp? and how it works in the terminal input but not in editors like vim/neovim?
image
image

@degouville
Copy link

degouville commented Sep 8, 2024

how it works in the terminal input

Wait... How does it work on your terminal ??? 👀😯

@daUnknownCoder
Copy link

how it works in the terminal input

Wait... Hoe does it work on your terminal ??? 👀😯

i works while we type >= or == or something, when we press enter to send the command, it reverts to the non ligaturized form and it doesnt work in text editors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests