Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we automatically set the baseUrl for Cypress? #847

Closed
chrisvfritz opened this issue Feb 16, 2018 · 2 comments
Closed

Could we automatically set the baseUrl for Cypress? #847

chrisvfritz opened this issue Feb 16, 2018 · 2 comments

Comments

@chrisvfritz
Copy link
Contributor

I might be missing something, but it looks like the only reason we need to set the VUE_DEV_SERVER_URL env var for Cypress is because we don't set the baseUrl. What would you think about replacing:

'--env', `VUE_DEV_SERVER_URL=${url}`,

with:

'--config', `baseUrl=${url}`,

in @vue/cli-plugin-unit-jest/index.js?

Then in Cypress tests, we wouldn't have to write:

cy.visit(Cypress.env('VUE_DEV_SERVER_URL'))

but could instead simplify to:

cy.visit('/')
@yyx990803
Copy link
Member

Ah cool, wasn't aware of the baseUrl option. Feel free to open a PR.

@yyx990803
Copy link
Member

Closed via #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants