fix(cli-plugin-eslint): remove base rules from ui (#2029)

vuejs · Aug 1, 2018 · 1e10161 · 1e10161
1 parent 7953d83
commit 1e10161
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/@vue/cli-plugin-eslint/__tests__/ui.spec.js b/packages/@vue/cli-plugin-eslint/__tests__/ui.spec.js
@@ -112,17 +112,26 @@ describe('getEslintPrompts', () => {
     'dolor': {
       meta: {
         docs: {
-          category: 'base',
+          category: 'strongly-recommended',
           description: 'Dolor description',
           url: 'http://test.com/dolor'
         }
       }
+    },
+    'sit': {
+      meta: {
+        docs: {
+          category: 'base',
+          description: 'Sit description',
+          url: 'http://test.com/sit'
+        }
+      }
     }
   }
 
   const prompts = getEslintPrompts(data, rules)
 
-  it('creates an array with three settings', () => {
+  it('creates an array with 3 settings, leaving out category "base"', () => {
     expect(prompts).toHaveLength(3)
   })
 
@@ -147,7 +156,7 @@ describe('getEslintPrompts', () => {
     expect(prompts[2].choices).toHaveLength(4)
   })
 
-  it('sets a default value to "ERROR" for rule that belong to the choosen config', () => {
+  it('sets a default value to "ERROR" for rule that belong to the chosen config', () => {
     expect(prompts[0].default).toBe('"error"')
     expect(prompts[1].default).toBe('"error"')
     expect(prompts[2].default).toBe('"off"')

diff --git a/packages/@vue/cli-plugin-eslint/ui/configDescriptor.js b/packages/@vue/cli-plugin-eslint/ui/configDescriptor.js
@@ -1,7 +1,6 @@
 const CONFIG = 'org.vue.eslintrc'
 
 const CATEGORIES = [
-  'base',
   'essential',
   'strongly-recommended',
   'recommended',

diff --git a/packages/@vue/cli-ui/locales/en.json b/packages/@vue/cli-ui/locales/en.json
@@ -584,7 +584,6 @@
               "essential": "Essential",
               "strongly-recommended": "Strongly recommended",
               "recommended": "Recommended",
-              "use-with-caution": "Use with caution",
               "uncategorized": "Uncategorized"
             },
             "setting": {