Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab extension logo #461

Closed
martinRenou opened this issue Nov 5, 2019 · 4 comments · Fixed by #1092
Closed

JupyterLab extension logo #461

martinRenou opened this issue Nov 5, 2019 · 4 comments · Fixed by #1092

Comments

@martinRenou
Copy link
Member

martinRenou commented Nov 5, 2019 •
edited
Loading

I would suggest not using the spinner logo for the JupyterLab extension button.

I suppose this logo with a transparent background would be better:
BLEU-illustration-2
@jtpio
Copy link
Member

jtpio commented Nov 6, 2019

Good idea 👍

Also a bit cropped, maybe something like this:

image

@martinRenou
Copy link
Member Author

martinRenou commented Nov 6, 2019 •
edited
Loading

Yes! Wasn't there a size requirement for the button logo since JupyterLab 1.0? I remember there was an issue with the logo when JLab 1.0 was released.

@jtpio
Copy link
Member

jtpio commented Nov 6, 2019

As long as we optimize the paths and try to respect the dimensions of the existing one, that should be fine.

@jtpio
Copy link
Member

jtpio commented Nov 6, 2019

And we'll need another version for the dark theme too.

@martinRenou martinRenou mentioned this issue Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JupyterLab extension logo martinRenou/voila
2 participants
@jtpio @martinRenou