Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropped voila-square icon #219

Closed
jtpio opened this issue Jun 11, 2019 · 6 comments · Fixed by #222
Closed

Cropped voila-square icon #219

jtpio opened this issue Jun 11, 2019 · 6 comments · Fixed by #222

Comments

@jtpio
Copy link
Member

jtpio commented Jun 11, 2019

The voila square icon seems to be cropped on the right side and doesn't look symmetrical:

image

https://github.com/QuantStack/voila/blob/master/docs/source/voila-square.svg

@SylvainCorlay
Copy link
Member

@jtpio thanks! We should probably free to fix it.

Although we should not spend too much time on logos as we are working with a prefessional designer that we work on the entire visual identity of voila, and the gallery.

@SylvainCorlay
Copy link
Member

Note: that spacing is merely the one from the font used to make that placeholder logo.

@jtpio
Copy link
Member Author

jtpio commented Jun 11, 2019

This squared version is not used yet but it would be interesting to have it for the templates and the JupyterLab extension.

@SylvainCorlay
Copy link
Member

How about adding whitespace above and below so that it is not cropped instead and keepa the same spacing?

@jtpio
Copy link
Member Author

jtpio commented Jun 11, 2019

Yes good point, then it has the same width and height.

Although it seems to be rendering fine in Chrome and Inkscape, which might be related to the text element within the svg.

For now I converted a copy of it to paths so we can start using it in #217.

@SylvainCorlay
Copy link
Member

We should convert the object to a path in inkscape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants