Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Geist to Google Fonts #99

Open
yanone opened this issue Apr 11, 2024 · 10 comments
Open

Onboarding Geist to Google Fonts #99

yanone opened this issue Apr 11, 2024 · 10 comments

Comments

@yanone
Copy link

yanone commented Apr 11, 2024

Hello.

I've been commissioned to onboard Geist to Google Fonts.

Here are a few things I found that we would require to change:

  • License file as OFL.txt
  • A bunch of metadata changes regarding the copyright
  • UltraLight instance renamed to ExtraLight
  • Vertical metrics changed so that line gap becomes 0, gap instead added to ascender and descender values
  • Fonts to be built with gftools builder
  • Font binaries to be present in the repository file structure.

Normally, I would make those changes and send you a PR back. But at least one of them (UltraLight instance name) may break existing text, so I wanted to communicate about that first. I mean, fonts hosted on GoogleFonts are in a separate environment to existing Geist fonts, but it may be inconvenient to keep two versions of sources around. I may also be able to come up with a build script that can rename the instance and not change the source.

Looking forward to your reply.

@yanone yanone added the bug Something isn't working label Apr 11, 2024
@guidoferreyra guidoferreyra removed the bug Something isn't working label Apr 11, 2024
@guidoferreyra
Copy link
Collaborator

guidoferreyra commented Apr 11, 2024

Hi @yanone! I’m helping the designers team to solve some issues and improve the tech quality of the font. After #25 we have been discusing internally about onboarding to GF and I mentioned the required breaking changes. It‘s very likely that those changes will be done to avoid having different versions of Geist but it will happen in the next month or so.

I will keep you posted.

@yanone
Copy link
Author

yanone commented Apr 11, 2024

Excellent, thank you.

@davelab6
Copy link

We also need to resolve the rfn which can be done by someone from vercel emailing [email protected] with an rfn permission, there's an example email in the gf guide :) https://googlefonts.github.io/gf-guide/license-file.html

@Kitenite
Copy link

This would be very helpful, thank you!

@yanone
Copy link
Author

yanone commented Jun 13, 2024

@guidoferreyra What's the status here?

@leonardobetti
Copy link

any news?

@guidoferreyra
Copy link
Collaborator

hi @yanone we are resuming on the work this month to keep doing fixes and start to prepare the fonts for onboarding. There are some breaking issues taht needs to be done before the family goes to GF.
Following @davelab6 comment I will connect Vercel people with you this week.

@yanone
Copy link
Author

yanone commented Jun 16, 2024

Thank you for the update. I'll be out for July and August, so not much time left. If the fonts are ready during that time, better connect with Dave about handing the work to another onboarder. But summers are generally slow as other people also take time off.

@chrissimpkins
Copy link

Re-assigning from Yanone to @vv-monsalve. Let's see if we can land this in Fonts in Q3

@guidoferreyra
Copy link
Collaborator

A temporary repo for the non mono family it’s available here. I’m having an issue with customize.py see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants