Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment action missing from AP model #2020

Closed
pkothare opened this issue Jun 7, 2024 · 2 comments
Closed

Assessment action missing from AP model #2020

pkothare opened this issue Jun 7, 2024 · 2 comments
Labels

Comments

@pkothare
Copy link

pkothare commented Jun 7, 2024

Describe the bug

The content on the OSCAL site doesn't match the model. The content on https://pages.nist.gov/OSCAL/resources/concepts/layer/assessment/assessment-plan/ states that the assessment plan should contain a field for assessment actions, but I couldn't find it in the JSON/XML model, nor any references to it in the metaschema. Unsure if it's a bug or if it just hasn't been released yet. Either the model or content should be updated to improve accuracy.

image

Who is the bug affecting

Content consumers of the OSCAL site.

What is affected by this bug

OSCAL Content, Documentation, Metaschema, Modeling, Website

How do we replicate this issue

Visit https://pages.nist.gov/OSCAL/resources/concepts/layer/assessment/assessment-plan/ and compare it to the JSON outline in https://pages.nist.gov/OSCAL-Reference/models/v1.1.2/assessment-plan/json-outline/

Expected behavior (i.e. solution)

The documentation should match the model.

Other comments

No response

Revisions

No response

@pkothare pkothare added the bug label Jun 7, 2024
@iMichaela
Copy link
Contributor

Thank you for reporting the bug - It is the diagram that needs to be updated. We are in the process of reviewing all pages for accuracy, consistency, usability and accessibility.

Under the assessment-plan/assessment -assets there are tasks that documents scheduled events or milestone, which may be associated with a series of assessment actions. This is a more generic way of allowing the assessment planner to define tasks of type milestoneor oftype action`.

The reposted bug exists and we acknowledge the diagram needs to be updated.
However, the issue belongs to the OSCAL Pages repo as the page directs the reader at the bottom through the Improve this page button, so would you, @pkothare , be so kind and submit the bug in the right repository? It would be greatly appreciated and would allow you to track easier the status of the bug you reposted.
On the page https://pages.nist.gov/OSCAL/resources/concepts/layer/assessment/assessment-plan/ one can click the "Improve this page" at the bottom of the page to be directed to the correct repository and the page https://github.com/usnistgov/OSCAL-Pages/blob/develop/src/content/resources/concepts/layer/assessment/assessment-plan/_index.md. This issue can then be closed here with the note pointing to the issue in the proper repo.
If this ask is too complicated, we can manage cross repo bug reports on your behalf. Thank you again for reporting it.

@pkothare
Copy link
Author

pkothare commented Jun 7, 2024

Thank you for clarifying @iMichaela, I opened the issue at: usnistgov/OSCAL-Pages#77.

@pkothare pkothare closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants