Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: typescript-eslint/typescript-eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.57.1
Choose a base ref
...
head repository: typescript-eslint/typescript-eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.58.0
Choose a head ref
  • 17 commits
  • 47 files changed
  • 11 contributors

Commits on Apr 5, 2023

  1. chore(deps): update dependency glob to v9.3.4 (#6846)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    eed1ea4 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency @types/react to v18.0.32 (#6847)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e94f24c View commit details
    Browse the repository at this point in the history
  3. test(website): add AST viewer test case (#6275)

    * test(website): Add AST viewer test case
    
    * Update packages/website/tests/playground.spec.ts
    
    * test(website): workaround for AST viewer
    failing test case
    
    * test(website): remove workaround for failing test
    
    ---------
    
    Co-authored-by: Josh Goldberg <[email protected]>
    tapanprakasht and JoshuaKGoldberg authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    75806c9 View commit details
    Browse the repository at this point in the history
  4. feat(eslint-plugin): [no-unsafe-enum-comparison] add rule (#6107)

    * feat: adding enums to member-ordering rule
    
    * feat(eslint-plugin): [strict-enums] adding check for null/undefined
    
    * feat(eslint-plugin): [strict-enums] refactoring tests to separate files
    
    * feat(eslint-plugin): [strict-enums] allowing more operators
    
    * fix(eslint-plugin): [strict-enums] adding union test
    
    * fix(eslint-plugin): [strict-enums] refactoring + adding failing class
    test
    
    * fix(eslint-plugin): [strict-enums] adding constraint code
    
    * fix(eslint-plugin): [strict-enums] better eslint messages
    
    * fix(eslint-plugin): [strict-enums] removing vscode setting changes
    
    * fix: changing function definition to reflect reality
    
    * fix: pass string enum literal into function that take string
    
    * fix: allow passing enums to functions with any/unknown
    
    * fix: using flags instead of names
    also fixes for codebase
    
    * fix: adding test that breaks the rule
    
    * fix: adding test for variadic functions
    
    * fix: adding isSymbolFlagSet internally
    
    * fix: adding ignoring for remaining lint failures
    
    * fix: better comments
    
    * fix: broken test
    
    * fix: adding failing test for generic functions
    
    * fix: refactoring tests + adding tests
    
    * fix: refactoring enum helper function locations
    
    * fix: cleanup
    
    * fix: refactoring + fixing tests
    
    * fix: more tests
    
    * fix: refactoring and making tests pass
    
    * fix: adding array code, all tests pass now
    
    * fix: adding failing test
    
    * fix: allow empty arrays
    
    * fix: adding logic for arrays with no enums
    
    * fix: adding more tests
    
    * fix: fixing test
    
    * fix: fixing linter
    
    * fix: reverting comment fixes
    
    * fix: removing refactor
    
    * fix: removing fixes to dot-notation
    
    * fix: removing semi refactor
    
    * fix: removing jest logic
    
    * fix: removing comparison operators check
    
    * fix: adding failing test
    
    * fix: making test pass
    
    * fix: adding comment
    
    * fix: adding back in bitwise operator checks since apparently they are
    needed
    
    * fix: remove bad comment
    
    * fix: removing unnecessary comments
    
    * fix: remove types from error messages
    
    * fix: removing isArray + refactoring
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * fix: removing strict-enums from recommended
    
    * fix: simplify
    
    * fix: undoing refactoring
    
    * fix: undoing refactoring
    
    * fix: moving tests into subdirectory
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * fix: adding failing test
    
    * fix: making boolean tests pass
    
    * fix: refactor tests + fix linter
    
    * fix: adding brads tests
    
    * fix: brads tests now pass
    
    * Update packages/eslint-plugin/docs/rules/strict-enums.md
    
    Co-authored-by: Joshua Chen <[email protected]>
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    Co-authored-by: Brad Zacher <[email protected]>
    
    * fix: make brads updates actually compile
    
    * Update strict-enums.ts
    
    * Continued fixing merge conflicts
    
    * Continued fixing the build
    
    * Passing build
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    * Update packages/eslint-plugin/src/rules/strict-enums.ts
    
    * A few more reverts
    
    * Just a bit more changing typeFlagUtils
    
    * Fixed strict-enums.md build
    
    * Convert tests to not pushing
    
    * Simplified the rule a whole bunch
    
    * Add back getEnumNames
    
    * Even more trimming down
    
    * ...and just a bit more
    
    * Undo some JSDoc changes
    
    * Progress: no-unsafe-enum-assignment is tested
    
    * A bit more testing for assignments, as requested
    
    * Finished testing and sharing
    
    * Added comparison operators
    
    * Added back no-unsafe-enum-comparison
    
    * Remove unrelated changes
    
    * Reduce coverage
    
    * Touched up docs
    
    ---------
    
    Co-authored-by: James <[email protected]>
    Co-authored-by: Brad Zacher <[email protected]>
    Co-authored-by: Joshua Chen <[email protected]>
    4 people authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    915f9c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. chore: update sponsors (#6858)

    Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
    Configuration menu
    Copy the full SHA
    940a857 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency @playwright/test to v1.32.2 (#6857)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 7, 2023
    Configuration menu
    Copy the full SHA
    98b7e6a View commit details
    Browse the repository at this point in the history
  3. chore(deps): update dependency @swc/core to v1.3.45 (#6859)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 7, 2023
    Configuration menu
    Copy the full SHA
    78a5e62 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. fix: update getLib for new TypeScript targets ES2021, ES2022 (#6782)

    parser: Update getLib for new TypeScript targets ES2021, ES2022
    
    Signed-off-by: Anders Kaseorg <[email protected]>
    andersk authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    1c04664 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency monaco-editor to ^0.37.0 (#6862)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    80dd751 View commit details
    Browse the repository at this point in the history
  3. docs: update monorepos typo (#6871)

    Update Monorepos.mdx
    
    fix typo and make it more accessible.
    sfavello authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    8728232 View commit details
    Browse the repository at this point in the history
  4. docs: update pull requests docs to include a how to ask section (#6872)

    * Update Pull_Requests.mdx
    
    added a how to ask section in pull request docs
    
    * Update docs/contributing/Pull_Requests.mdx
    
    change title
    
    Co-authored-by: Josh Goldberg ✨ <[email protected]>
    
    * Update docs/contributing/Pull_Requests.mdx
    
    Add proofreading change to add more clarity.
    
    Co-authored-by: Josh Goldberg ✨ <[email protected]>
    
    ---------
    
    Co-authored-by: Josh Goldberg ✨ <[email protected]>
    sfavello and JoshuaKGoldberg authored Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f0f83ce View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. chore(deps): update dependency typescript to v5.0.3 (#6823)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    3277c8c View commit details
    Browse the repository at this point in the history
  2. chore(deps): update babel to v7.21.4 (#6831)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d38fe33 View commit details
    Browse the repository at this point in the history
  3. chore(deps): update dependency eslint-plugin-deprecation to v1.4.1 (#…

    …6845)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0c55ea5 View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency webpack to v5.78.0 (#6815)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    ec24a92 View commit details
    Browse the repository at this point in the history
  5. fix(eslint-plugin): [unified-signatures] allow overloads with differe…

    …nt named and different number of parameters (#6877)
    NotWoods authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    939d665 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0c6b636 View commit details
    Browse the repository at this point in the history
Loading