Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send workspace invitation email from the logged-in user #7001

Open
FelixMalfait opened this issue Sep 12, 2024 · 6 comments
Open

Send workspace invitation email from the logged-in user #7001

FelixMalfait opened this issue Sep 12, 2024 · 6 comments
Assignees
@KoyalkarAditya
Labels
good first issue Good for newcomers prio: low scope: backend Issues that are affecting the backend side only size: short type: design improvement

Comments

@FelixMalfait
Copy link
Member

Current Behavior

Currently, invitations to workspaces are sent from the server's default message sender

CleanShot 2024-09-09 at 17 42 08

Desired Behavior

Invitations should appear to be sent by the person who created the invite.
e.g. if John Doe is logged in to Twenty and invites someone. Then the invite should be from "John Doe (via Twenty)". That's how Google Drive does it.
@FelixMalfait FelixMalfait added scope: backend Issues that are affecting the backend side only size: short type: design improvement prio: low good first issue Good for newcomers labels Sep 12, 2024
@KoyalkarAditya
Copy link

Can I work on this ?

@FelixMalfait
Copy link
Member Author

Sure!
Maybe wait for #6626 to be merged (it will be merged tonight) and then tomorrow you can do the followup PR.
It's probably here:
https://github.com/twentyhq/twenty/pull/6626/files#diff-238c844112a9e74b07c4b90d5cc70dd55ac32e014b8d91aae1fb5fc5e34cf561R171

@venom-10
Copy link

Hey @FelixMalfait, can I work on this now?

@FelixMalfait
Copy link
Member Author

@venom-10 sorry it's still ongoing! But by end of week it will be merged for sure.
It was replaced by #6804

@FelixMalfait
Copy link
Member Author

FelixMalfait commented Sep 22, 2024 •
edited
Loading

@venom-10 @KoyalkarAditya good to go! you can make the change (not sure who's still available)

@KoyalkarAditya
Copy link

sure will work on this

@Bonapara Bonapara mentioned this issue Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KoyalkarAditya KoyalkarAditya

Labels
good first issue Good for newcomers prio: low scope: backend Issues that are affecting the backend side only size: short type: design improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FelixMalfait @venom-10 @KoyalkarAditya