From 210711d0fd88f0c7f8191902ac1298d4e34226d5 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Wed, 4 Sep 2024 16:30:03 +0200 Subject: [PATCH 1/3] Handle ts2719 Signed-off-by: Matteo Collina --- source/lib/compiler.ts | 1 + source/lib/interfaces.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/source/lib/compiler.ts b/source/lib/compiler.ts index 3ca4e21..5f58cda 100644 --- a/source/lib/compiler.ts +++ b/source/lib/compiler.ts @@ -59,6 +59,7 @@ const expectErrorDiagnosticCodesToIgnore = new Set([ DiagnosticCode.AcceptsTooFewArgumentsToBeUsedAsDecoratorHere, DiagnosticCode.PropertyDoesNotExistOnTypeDidYouMean, DiagnosticCode.ErrorIsOfTypeUnknown, + DiagnosticCode.TwoDifferentTypesSameName, ]); type IgnoreDiagnosticResult = 'preserve' | 'ignore' | Location; diff --git a/source/lib/interfaces.ts b/source/lib/interfaces.ts index f2c5688..c9aab8b 100644 --- a/source/lib/interfaces.ts +++ b/source/lib/interfaces.ts @@ -58,6 +58,7 @@ export enum DiagnosticCode { IndexSignatureOnlyPermitsReading = 2542, NoOverloadExpectsCountOfArguments = 2575, ThisContextOfTypeNotAssignableToMethodOfThisType = 2684, + TwoDifferentTypesSameName = 2719, Type1IsMissingPropertiesFromType2Variant1 = 2739, Type1IsMissingPropertiesFromType2Variant2 = 2740, PropertyMissingInType1ButRequiredInType2 = 2741, From 918b60da6047f84ca8ae49cd6d06b71e8275e6de Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Wed, 4 Sep 2024 16:53:10 +0200 Subject: [PATCH 2/3] fixup Signed-off-by: Matteo Collina --- .../missing-diagnostic-code/index.test-d.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts b/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts index 5b6a7d5..0efd2d1 100644 --- a/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts +++ b/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts @@ -6,3 +6,16 @@ expectError(one('foo', 'bar')); // 'Found an error that tsd does not currently support (`ts2304`), consider creating an issue on GitHub.' expectError(undeclared = one('foo', 'bar')); + +// ts2719 +interface T { } +declare const a: T; +expectError(class Foo { + x: T; + constructor(a: T) { + this.x = a; + } + fn() { + this.x = a; + } +}) From d99bb3cd8f354f0ec0aeb3f64abc90142eb77327 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Thu, 5 Sep 2024 00:04:49 +0700 Subject: [PATCH 3/3] Update index.test-d.ts --- .../missing-diagnostic-code/index.test-d.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts b/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts index 0efd2d1..5b71687 100644 --- a/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts +++ b/source/test/fixtures/expect-error/missing-diagnostic-code/index.test-d.ts @@ -8,14 +8,14 @@ expectError(one('foo', 'bar')); expectError(undeclared = one('foo', 'bar')); // ts2719 -interface T { } +interface T {} declare const a: T; expectError(class Foo { - x: T; - constructor(a: T) { - this.x = a; - } - fn() { - this.x = a; - } + x: T; + constructor(a: T) { + this.x = a; + } + fn() { + this.x = a; + } })