Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131363 / 25.04 / Add link to forum #10753

Merged
merged 2 commits into from
Sep 27, 2024
Merged

NAS-131363 / 25.04 / Add link to forum #10753

merged 2 commits into from
Sep 27, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
Screenshot 2024-09-26 at 13 20 35

See ticket.

Affects Reasoning
Documentation New link added In feedback dialog on a non-enterprise system,

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 26, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 26, 2024 10:20
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team September 26, 2024 10:21
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131363: Add link to forum NAS-131363 / 25.04 / Add link to forum Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (2afce47) to head (c534adb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10753      +/-   ##
==========================================
+ Coverage   80.27%   80.29%   +0.01%     
==========================================
  Files        1571     1571              
  Lines       51704    51708       +4     
  Branches     5838     5838              
==========================================
+ Hits        41507    41519      +12     
+ Misses      10197    10189       -8     
Flag Coverage Δ
80.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) September 27, 2024 08:28
@AlexKarpov98 AlexKarpov98 merged commit 9c40ce8 into master Sep 27, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131363 branch September 27, 2024 09:12
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants