-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131093 / 25.04 / Remove EntityJobComponent #10733
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/app/modules/terminal/terminal.module.ts # src/app/pages/account/account.module.ts # src/app/pages/account/groups/groups.module.ts # src/app/pages/account/users/users.module.ts # src/app/pages/api-keys/api-keys.module.ts # src/app/pages/credentials/credentials.module.ts # src/app/pages/data-protection/data-protection.module.ts # src/app/pages/datasets/modules/encryption/encryption.module.ts # src/app/pages/datasets/modules/snapshots/snapshots.module.ts # src/app/pages/directory-service/directory-service.module.ts # src/app/pages/jobs/jobs-list.module.ts # src/app/pages/network/network.module.ts # src/app/pages/services/services.module.ts # src/app/pages/sharing/sharing.module.ts # src/app/pages/shell/shell.module.ts # src/app/pages/storage/modules/devices/devices.module.ts # src/app/pages/storage/modules/disks/disks.module.ts # src/app/pages/system/system.module.ts # src/app/pages/vm/vm.module.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10733 +/- ##
==========================================
+ Coverage 80.27% 80.59% +0.31%
==========================================
Files 1571 1570 -1
Lines 51657 51455 -202
Branches 5838 5807 -31
==========================================
- Hits 41469 41468 -1
+ Misses 10188 9987 -201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we keeping the EntityJobComponent. We don't need it anymore.
Yeah, forgot to remove the most important thing. |
Changes:
Removes last usages of EntityJobComponent.
Testing:
Test affected places.