Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Feature support is not implemented correctly #63

Open
trevjonez opened this issue Feb 28, 2020 · 1 comment
Open

Dynamic Feature support is not implemented correctly #63

trevjonez opened this issue Feb 28, 2020 · 1 comment
Labels
Accepting PR's This issue is decently defined, happy to review pull requests to resolve it bug help wanted

Comments

@trevjonez
Copy link
Owner

The similarity between the Application plugin and Dynamic Feature plugin in AGP made it seem as though the same implementation would work for both. This is not actually the case.

Lets setup a simple example of a project to use in a test so we can TDD through it.

@trevjonez trevjonez added the bug label Feb 28, 2020
@trevjonez
Copy link
Owner Author

more notes on this, I augmented the composer code to handle the multi-apk adb commands, but still don't have the agp integration to collect all the necessary apks done correctly.

Any help there would be appreciated, and feel free to assume a minimum AGP version of 4.+ if need be to make it work.

@trevjonez trevjonez added Accepting PR's This issue is decently defined, happy to review pull requests to resolve it help wanted labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PR's This issue is decently defined, happy to review pull requests to resolve it bug help wanted
Projects
None yet
Development

No branches or pull requests

1 participant