Add WebP support #9879
Merged
Add WebP support #9879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that we can't see this file type in Safari and Firefox which are currently released. |
|
@mayaeh the coming version of Firefox 56 will likely include WebP support. |
|
Update to this: Firefox 65 is now out and does support WebP. This includes Firefox for Android and Desktop, though not iOS. See https://www.mozilla.org/en-US/firefox/65.0/releasenotes/ |
Gargron
requested changes
Feb 1, 2019
| @@ -25,10 +25,10 @@ class MediaAttachment < ApplicationRecord | |||
|
|
|||
| enum type: [:image, :gifv, :video, :unknown] | |||
|
|
|||
| IMAGE_FILE_EXTENSIONS = ['.jpg', '.jpeg', '.png', '.gif'].freeze | |||
| IMAGE_FILE_EXTENSIONS = ['.jpg', '.jpeg', '.png', '.gif', '.webp'].freeze | |||
There was a problem hiding this comment.
How about this: Keep the support but remove the changes to the tooltip. Then it's future-proof without encouraging users to upload images that still aren't supported by Safari/iOS
Gargron
approved these changes
Feb 2, 2019
masanbol
pushed a commit
to masanbol/snoutsonline
that referenced
this pull request
Feb 3, 2019
This reverts commit 5092d17.
This was referenced Aug 16, 2019
Merged
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Add WebP support * Remove the changes to the tooltip refs: mastodon#9879 (review)
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Add WebP support * Remove the changes to the tooltip refs: mastodon#9879 (review)
Closed
This was referenced Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8165