-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serialization for columns of type "list" #2355
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We can look at what R does in unique.c about lists. |
Pretty sure this is a @hadley I'm not sure yet at what level we'll use |
> vctrs:::vec_hash(list(1:2,c(1L,2L)))
[1] "656ac61" "656ac61" |
I think we can probably close this issue; once dplyr can use vctrs, it can use the standard hashing approach defined there. |
Let's keep this open to remind us that we still need to enable it here once we have it in vctrs. |
in join (#2194) and distinct (#2222) operations.
We should be able to serialize all elements of a list efficiently by calling
R_Serialize()
for each. A specialized version ofJoinVisitorImpl
andVectorVisitor
would then operate on the serializations. Perhaps hashing the serialization will be good enough.The text was updated successfully, but these errors were encountered: