From bd2ee60eae26973244e094c1f28d737afd392e94 Mon Sep 17 00:00:00 2001 From: Jon Moss Date: Mon, 30 Jul 2018 16:11:46 -0400 Subject: [PATCH] src: remove unused env->vm_parsing_context_symbol MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Stopped being used via 77b52fd58f7398a81999c81afd21fe2e156c0766, was originally added in d932e802317f9f61bd10988189fa43ed03ad0f61. For the one remaining usecase inside of `lib/vm.js`, define a Symbol at the top of the file. PR-URL: https://github.com/nodejs/node/pull/22034 Reviewed-By: Gus Caplan Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig --- lib/vm.js | 3 +-- src/env.h | 1 - src/node_contextify.cc | 10 ---------- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/vm.js b/lib/vm.js index c813ca3049e3e0..3dd63fe2af1222 100644 --- a/lib/vm.js +++ b/lib/vm.js @@ -23,14 +23,13 @@ const { ContextifyScript, - kParsingContext, makeContext, isContext: _isContext, } = process.binding('contextify'); - const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes; const { isUint8Array } = require('internal/util/types'); const { validateInt32, validateUint32 } = require('internal/validators'); +const kParsingContext = Symbol('script parsing context'); class Script extends ContextifyScript { constructor(code, options = {}) { diff --git a/src/env.h b/src/env.h index 91ae7824281cb7..820c3a7fc38e01 100644 --- a/src/env.h +++ b/src/env.h @@ -359,7 +359,6 @@ struct PackageConfig { V(tls_wrap_constructor_function, v8::Function) \ V(tty_constructor_template, v8::FunctionTemplate) \ V(udp_constructor_function, v8::Function) \ - V(vm_parsing_context_symbol, v8::Symbol) \ V(url_constructor_function, v8::Function) \ V(write_wrap_template, v8::ObjectTemplate) diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 74b7c594d5f179..be4c0e5cf303d7 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -609,16 +609,6 @@ class ContextifyScript : public BaseObject { target->Set(class_name, script_tmpl->GetFunction()); env->set_script_context_constructor_template(script_tmpl); - - Local parsing_context_symbol = - Symbol::New(env->isolate(), - FIXED_ONE_BYTE_STRING(env->isolate(), - "script parsing context")); - env->set_vm_parsing_context_symbol(parsing_context_symbol); - target->Set(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "kParsingContext"), - parsing_context_symbol) - .FromJust(); }