Remove /vendor from global gitignore #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit moved all ignores to gitignore. 01b7a29 Rails 7 now expects the vendor directory to be committed as it creates directories within vendor with `.keep` files. * Revert back to having a separate `.agignore` file for things we want to be ignored by `ag` (the_silver_searcher) Even though this link https://github.com/ggreer/the_silver_searcher/wiki/Advanced-Usage says that `.aginore` was removed in version 2.0.0, it's still in the man page `man ag` and you can see that it's included when running `ag --debug` and that on version 2.2.0. * Closes #697
jferris
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7 now expects the vendor directory to be committed as it creates
directories within vendor with
.keepfiles..agignorefile for things we want to be ignored by
ag(the_silver_searcher)Even though this link https://github.com/ggreer/the_silver_searcher/wiki/Advanced-Usage
says that
.aginorewas removed in version 2.0.0, it's still in theman page
man agand you can see that it's included when runningag --debugand that's on version 2.2.0./vendorin.gitignorebreaks Rails 7 deploys #697