Specify prompt declaration in .zshrc, not .zlogin

[geoffharcourt]

Related to #214. Because .zlogin loads later in the load path than .zshrc, it is difficult to override the prompt with your own custom prompt.

Also, .zlogin only loads for login shells. Doesn't it make sense to load the prompt in .zshrc so that it's available for non-login, interactive shells?

It looks like both of these issues (overridability, making custom prompts available in non-login shells) could be resolved if the prompt line at https://github.com/thoughtbot/dotfiles/blob/master/zlogin#L20 in .zlogin could be moved to .zshrc. PR #214 fixes the overridability issue, but requires declaring the override prompt in two places (.zshrc and .zlogin.local) if you wish to have a custom prompt for non-login shells.

[mikegee]

+1

When I merged the latest changes a while back, I had to change my shell in iterm from just zsh to zsh --login Just to fix my prompt.

[geoffharcourt]

It looks like this was implemented by @gylaz in 7007a86. Closing.