Missing documentation about Vundle?

[sohara]

I'm not sure from the README file but it seems to imply that following the installation instructions should result in a working Vim install with configured vim bundles already installed. Is this correct?

I followed all the installation instructions and when I run vim I get the following output:

Error detected while processing /Users/sohara/.vimrc.bundles:
line    5:
E117: Unknown function: vundle#rc
line    8:
E492: Not an editor command: Bundle 'gmarik/vundle'
line   11:
E492: Not an editor command: Bundle 'croaky/vim-colors-github'
line   12:
E492: Not an editor command: Bundle 'danro/rename.vim'
line   13:
E492: Not an editor command: Bundle 'kchmck/vim-coffee-script'
line   14:
E492: Not an editor command: Bundle 'kien/ctrlp.vim'
line   15:
E492: Not an editor command: Bundle 'scrooloose/syntastic'
line   16:
E492: Not an editor command: Bundle 'thoughtbot/vim-rspec'
line   17:
E492: Not an editor command: Bundle 'tpope/vim-bundler'
line   18:
E492: Not an editor command: Bundle 'tpope/vim-cucumber'
line   19:
E492: Not an editor command: Bundle 'tpope/vim-endwise'
line   20:
E492: Not an editor command: Bundle 'tpope/vim-fugitive'
line   21:
E492: Not an editor command: Bundle 'tpope/vim-rails'
line   22:
E492: Not an editor command: Bundle 'tpope/vim-surround'
line   23:
E492: Not an editor command: Bundle 'tsaleh/vim-matchit'
line   24:
E492: Not an editor command: Bundle 'vim-scripts/ctags.vim'
line   25:
E492: Not an editor command: Bundle 'vim-scripts/tComment'
Error detected while processing /Users/sohara/.vimrc:
line   78:
E185: Cannot find color scheme 'github'

It seems as though there is some additional installation step which is not documented, e.g. installing the Vundle plugin manually.

I ran git clone https://github.com/gmarik/vundle.git ~/.vim/bundle/vundle then started Vim and ran :BundleInstall as suggested by the Readme on the Vundle project. However if this is normally a required step then I find it surprising that no reference is made to it in the documentation.

[sohara]

It looks like this shell script is supposed to get run at some point during the git cloning or afterward?
https://github.com/thoughtbot/dotfiles/blob/master/hooks/post-up

[pbrisbin]

Try running the rcup command with the -k option. There was a recently-fixed bug where after-hooks were not run by default which may be causing this issue.

[sohara]

Ok, should I send a PR for a change to the Readme? Also it's pretty obvious but might be worth documenting that one should cd into ~/dotfiles prior to running brew bundle?

[pbrisbin]

Should I send a PR for a change to the Readme?

When did you install rcm? If the current version doesn't contain the hook-fix, I'd rather see that addressed before adding a workaround to the README. /cc @mike-burns

Also it's pretty obvious but might be worth documenting that one should cd into ~/dotfiles prior to running brew bundle?

If you find anything unclear, a PR is always welcome.

[sohara]

I installed rcm on one system yesterday and another system this morning. I had the same result both times (without passign the -k flag). I was just suggesting a PR to document passing the -k flag until such time as it is no longer required. I'll send a PR and we can go from there.

[mike-burns]

@sohara which version of rcm are you using?

rcup -V

[sohara]

@mike-burns I'm using 1.1.0. I installed using homebrew.

[MattMSumner]

Just installed rcup 1.1.0 and has the same issue of vundler not being installed. Running rcup with the -k flag solved the problem i.e:

rcup -k -d dotfiles -x README.md -x LICENSE

Looking through man rcup the -k flag runs pre and post hooks. Not sure why the post hook isn't getting run without the flag.

[pbrisbin]

There was a bug in rcm 1.1 that hooks were not run by default (as was intended). rcm 1.2 has the fix and has been released.

[MattMSumner]

Awesome. Thanks!