Skip to content

Commit

Permalink
refactor: update INotify impls
Browse files Browse the repository at this point in the history
  • Loading branch information
postspectacular committed Aug 3, 2023
1 parent 26cf9d1 commit cbdc527
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 13 deletions.
6 changes: 4 additions & 2 deletions packages/atom/src/history.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,11 +374,13 @@ export class History<T> implements IHistory<T>, INotify<HistoryEventType> {

/** {@inheritDoc @thi.ng/api#INotify.addListener} */
// @ts-ignore: mixin
addListener(id: HistoryEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: HistoryEventType, fn: Listener<HistoryEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.removeListener} */
// @ts-ignore: mixin
removeListener(id: HistoryEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: HistoryEventType, fn: Listener<HistoryEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.notify} */
// @ts-ignore: mixin
Expand Down
7 changes: 4 additions & 3 deletions packages/ecs/src/components/acomponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,13 @@ export abstract class AComponent<K extends string, VALUES, GET, SET>
}

// @ts-ignore: arguments
addListener(id: ComponentEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: ComponentEventType, fn: Listener<ComponentEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.removeListener} */
// prettier-ignore
// @ts-ignore: arguments
removeListener(id: ComponentEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: ComponentEventType, fn: Listener<ComponentEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.notify} */
// @ts-ignore: arguments
Expand Down
6 changes: 4 additions & 2 deletions packages/ecs/src/ecs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,13 @@ export class ECS<SPEC> implements INotify<ECSEventType> {

/** {@inheritDoc @thi.ng/api#INotify.addListener} */
// @ts-ignore: mixin
addListener(id: ECSEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: ECSEventType, fn: Listener<ECSEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.removeListener} */
// @ts-ignore: mixin
removeListener(id: ECSEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: ECSEventType, fn: Listener<ECSEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.notify} */
// @ts-ignore: mixin
Expand Down
6 changes: 4 additions & 2 deletions packages/router/src/basic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ export class BasicRouter implements INotify<RouterEventType> {

/** {@inheritDoc @thi.ng/api#INotify.addListener} */
// @ts-ignore: arguments
addListener(id: RouterEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: RouterEventType, fn: Listener<RouterEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.removeListener} */
// @ts-ignore: arguments
removeListener(id: RouterEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: RouterEventType, fn: Listener<RouterEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.notify} */
// @ts-ignore: arguments
Expand Down
8 changes: 6 additions & 2 deletions packages/timestep/src/timestep.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,13 @@ export class TimeStep implements INotify<TimeStepEventType> {
}

// @ts-ignore mixin
addListener(id: TimeStepEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: TimeStepEventType, fn: Listener<TimeStepEventType>, scope?: any): boolean { }

// @ts-ignore mixin
removeListener(id: TimeStepEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: TimeStepEventType, fn: Listener<TimeStepEventType>, scope?: any): boolean { }

// @ts-ignore mixin
notify(event: Event<TimeStepEventType>): boolean {}

Expand Down
6 changes: 4 additions & 2 deletions packages/wasm-api/src/bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,13 @@ export class WasmBridge<T extends WasmExports = WasmExports>

/** {@inheritDoc @thi.ng/api#INotify.addListener} */
// @ts-ignore: mixin
addListener(id: BridgeEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
addListener(id: BridgeEventType, fn: Listener<BridgeEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.removeListener} */
// @ts-ignore: mixin
removeListener(id: BridgeEventType, fn: Listener, scope?: any): boolean {}
// prettier-ignore
removeListener(id: BridgeEventType, fn: Listener<BridgeEventType>, scope?: any): boolean {}

/** {@inheritDoc @thi.ng/api#INotify.notify} */
// @ts-ignore: mixin
Expand Down

0 comments on commit cbdc527

Please sign in to comment.