refactor(dsp): update spectrumPow() arg order

- swap `window` & `n` args, since `window` more likely to be provided
thi-ng · Dec 22, 2020 · be1b615 · be1b615
1 parent f67f820
commit be1b615
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/dsp/src/fft/fft.ts b/packages/dsp/src/fft/fft.ts
@@ -365,15 +365,15 @@ export const spectrumMag = (
  *
  * @param complex
  * @param db
- * @param n
  * @param window
+ * @param n
  * @param out
  */
 export const spectrumPow = (
     complex: ComplexArray,
     db = false,
-    n = complex[0].length / 2,
     window: number | NumericArray = 2 / complex[0].length,
+    n = complex[0].length / 2,
     out: NumericArray = []
 ) => {
     const [real, img] = complex;

diff --git a/packages/dsp/test/fft.ts b/packages/dsp/test/fft.ts
@@ -75,8 +75,8 @@ describe("fft", () => {
         const norm = normalizeFFT(copyComplex(fwd), win);
 
         assert(eqDelta(spectrumMag(norm)[I], A));
-        assert(eqDelta(spectrumPow(norm, false, N / 2, 1)[I], A / 2));
-        assert(eqDelta(spectrumPow(norm, true, N / 2, 1)[I], magDb(A)));
+        assert(eqDelta(spectrumPow(norm, false, 1)[I], A / 2));
+        assert(eqDelta(spectrumPow(norm, true, 1)[I], magDb(A)));
         assert(eqDelta(spectrumPhase(norm)[I], (1 / 12) * TAU));
     });
 });