Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui for glyph editor #2

Open
nkint opened this issue Feb 15, 2020 · 3 comments
Open

Ui for glyph editor #2

nkint opened this issue Feb 15, 2020 · 3 comments

Comments

@nkint
Copy link

nkint commented Feb 15, 2020

Hi Karsten,

I've tried to add an editor box with an input text for each glyph like this :
image

The state code is based on this hdom example but it has some error.

If there is only 1 glyphs editor box... it works: the re-render when input text changes works. But with more glyphs... re-render does not works anymore.
You can see this behaviour by toggle comment here: https://github.com/thi-ng/font/pull/1/files#diff-fbea1a62407700a59a4adae2175239a5R24

I think it is related with innerHtmlWrapperSvg that I took from this hdom example

@postspectacular
Copy link
Member

Hey @nkint - just checked out your fork and tried to build it, but the data import is missing (forgot to check in the file?). Am on the road this weekend, but will try again once the file is there - can't tell what's wrong without building it... sorry & thank you!!!

@nkint
Copy link
Author

nkint commented Feb 16, 2020

Hi @postspectacular yes sorry the file was not commited 🤦‍♂️
Just added.

@postspectacular
Copy link
Member

Will check it out and report back asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants