Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for directory using DAV:iscollection #29

Merged
merged 3 commits into from
Jan 17, 2018
Merged

check for directory using DAV:iscollection #29

merged 3 commits into from
Jan 17, 2018

Conversation

miklcct
Copy link

@miklcct miklcct commented Apr 3, 2017

The current check for directory, which thinks an item is a directory if the content-length is empty of 0, is error-prone and fails on my IIS server where the client returns a string "0" for directories. It may also fail if there is an empty file in the directory.

This fix properly checks for a directory using DAV:iscollection.

@Teods
Copy link

Teods commented Nov 29, 2017

This PR is waiting for ages, could you please validate and merge it ?

It will fix the bug of the "has" function who return "true" for whatever you write has path because the normalize function always return an non-empty array who pass the (bool) check.

@frankdejonge frankdejonge merged commit db85f8c into thephpleague:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants