Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate TestTSDBStore_SeriesAccessWithDelegateClosing and chunks writability #4266

Closed
yeya24 opened this issue May 20, 2021 · 2 comments
Closed

Comments

@yeya24
Copy link
Contributor

yeya24 commented May 20, 2021

#4247 updates Prometheus dependency and includes upstream pr prometheus/prometheus#8723.

This makes test https://github.com/thanos-io/thanos/blob/main/pkg/store/tsdb_test.go#L450 indeterministic. Some chunks are writable and some chunks are still not writable. We skip this test case for now and we need more investigation on it to see if there is any regression.

@stale
Copy link

stale bot commented Jul 19, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 19, 2021
@stale
Copy link

stale bot commented Aug 3, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant