Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use panic instead of silently ignoring errors #65

Closed
hallazzang opened this issue Oct 19, 2021 · 0 comments · Fixed by #79
Closed

fix: use panic instead of silently ignoring errors #65

hallazzang opened this issue Oct 19, 2021 · 0 comments · Fixed by #79
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hallazzang
Copy link
Contributor

When an error occurs, we should panic if the error is significant or rarely occurs, to prevent silently ignoring important errors.

Some of examples are:

budgetSourceAcc, err := sdk.AccAddressFromBech32(budgetSource)
if err != nil {
continue
}

collectionAcc, err := sdk.AccAddressFromBech32(budget.CollectionAddress)
if err != nil {
continue
}

if err := k.bankKeeper.InputOutputCoins(ctx, inputs, outputs); err != nil {
continue
}

@hallazzang hallazzang added the bug Something isn't working label Oct 19, 2021
@dongsam dongsam added this to the Budget v1.0 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants