Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move element distribution code from DgElementArray to free function #6028

Merged
merged 2 commits into from
May 29, 2024

Conversation

nilsdeppe
Copy link
Member

Proposed changes

I'll need to share this with the nodegroup code.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This allows us to share the creation code between the evolution array and
nodegroup implementations
@nilsdeppe nilsdeppe requested a review from kidder May 24, 2024 02:34
Comment on lines +139 to 140
quadrature,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is formatting really ok with this space in the function call?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what you mean by "okay". Clang format doesn't remove single blank lines (it does combine multiple blank lines into one!) and I found it easier to read the function call separating the slew of size_ts that represent hardware things from the parts that are tied to the element info 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do

Comment on lines +139 to 140
quadrature,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do

@knelli2 knelli2 merged commit c4b3907 into sxs-collaboration:develop May 29, 2024
22 checks passed
@nilsdeppe nilsdeppe deleted the add_threading_11 branch August 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants