-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move element distribution code from DgElementArray to free function #6028
Move element distribution code from DgElementArray to free function #6028
Conversation
This allows us to share the creation code between the evolution array and nodegroup implementations
quadrature, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is formatting really ok with this space in the function call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure what you mean by "okay". Clang format doesn't remove single blank lines (it does combine multiple blank lines into one!) and I found it easier to read the function call separating the slew of size_t
s that represent hardware things from the parts that are tied to the element info 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do
quadrature, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm do we have a convention for this? I think there are many other instances of function calls that have a bajillion parameters that are difficult to read. Some have comments between lines to make it easier, some don't. Not gonna hold up this PR though, but we should probably figure out what to do
Proposed changes
I'll need to share this with the nodegroup code.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments