Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand list of TciStatus #6005

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ncorsobh
Copy link
Contributor

Proposed changes

Expands the list of the number of TciStatus options for greater precision in debugging TCI problems. In this case, takes the three options that formerly resulted in TciStatus = +1 and separated them into separate statuses.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this :)

@nilsdeppe nilsdeppe merged commit ba94157 into sxs-collaboration:develop May 21, 2024
21 of 22 checks passed
@ncorsobh ncorsobh deleted the ExpandTci branch May 28, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants