Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit to time step of packet in high opacity region #5998

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ffoucart
Copy link
Contributor

Proposed changes

Implement limit to the time step that a packet can take if close to a cell boundary in a high opacity region (to deal more accurately with regions where only packets very close to a cell boundary can escape that cell).
This improves the accuracy of e.g. the optically thick sphere test for large optical depths.

Upgrade instructions

None

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@ffoucart ffoucart mentioned this pull request Jun 4, 2024
3 tasks
kidder
kidder previously approved these changes Jun 4, 2024
@ffoucart
Copy link
Contributor Author

ffoucart commented Jun 4, 2024

Well, the auto-merge feature didn't go great... let me resolve the conflict with develop...

@kidder kidder enabled auto-merge June 4, 2024 20:06
@kidder kidder merged commit 393d0e2 into sxs-collaboration:develop Jun 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants