Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken codecov links in Readme #5984

Merged
merged 2 commits into from
May 13, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented May 11, 2024

Codecov requires API tokens now.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the ci/cd Continuous integration & deployment label May 11, 2024
nilsdeppe
nilsdeppe previously approved these changes May 12, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :D Thank you!!

@nilsdeppe nilsdeppe merged commit e12e01b into sxs-collaboration:develop May 13, 2024
21 of 22 checks passed
@nilsvu nilsvu deleted the fix_codecov branch May 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants