Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look closer at the bitsAllocated = 1 case for BigEndian Data. #213

Open
suyashkumar opened this issue Aug 22, 2021 · 0 comments
Open

Look closer at the bitsAllocated = 1 case for BigEndian Data. #213

suyashkumar opened this issue Aug 22, 2021 · 0 comments

Comments

@suyashkumar
Copy link
Owner

In #212, the implementation assumes LittleEndian order on reading the data in the code, but the tests with data written out using BigEndian data (written using binary.Write) pass with no issues (perhaps because the reader is BigEndian aware and running on a LittleEndian machine?). Either way, this is a placeholder to remind me to take a closer look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant