Keyboard is not focused to value input when editing modulation values from context menu

[xard-dev]

Bug Description:
Keyboard is not focused to value input when editing modulation values from context menu and the field needs to be clicked before a value can be written.

Surge Version:

• Version: Surge XT 0.99.nightly.320cd70
• Plugin Type: VST3, LV2
• Bitness: 64-bit

Reproduction Steps:

1. Open control like Filter cutoff context menu
2. Click on any modulation edit icons OR click Add modulation from context menu item adding a new modulation target
3. Type value

Expected Behavior:
A value can be inserted directly.

Screenshots:

Computer Information (please complete the following information):

• OS: Ubuntu 20.04
• Host: Carla, Ardour
• Version: 2.1.0, 6.9

Additional Information:
When opening context menu for a control and choosing Edit value the keyboard focus is in the popup field and the value can be inserted directly.

[baconpaul]

OK this isn't a problem on mac but i happen to be in linux now so let me look

[baconpaul]

oh and confirmed that on linux it does happen. and it is annoying.

[baconpaul]

hmm i have no idea how to fix this
it's super annoying but i don't think i would block on it. I thought it might be our custom focus handlers but it isn't.

Oh @xard-dev I'm also interested if that , as . works properly with the parsing?

[xard-dev]

For my regional settings decimal separator comma , works as expected but period . is ignored and the values after period are discarded.

[xard-dev]

And If I temporarily change to LC_ALL=C the period . is used instead of comma , as expected.

[baconpaul]

great thanks!

[j5v]

I came here to report this bug.
What might help: While the 'edit value' box is being displayed, I can right-click again and again select the edit icon in the context menu. If I can get the value to focus, then repeated attempts will always be in focus. However, if the 'edit value' box is not focused, then it might, or might not focus next time.
I suspect a race condition between display and focus.

[baconpaul]

Yeah it’s all single threaded but I wonder if I need a show message to get a cycle before the focus message. Excellent observation

[eigenvoid]

I have this bug too on Surge XT 1.3.4 on Arch Linux with KDE and X11. Right-clicking on a slider and choosing "Edit Value," the value box will not be focused, and you have to click it a few times to be able to edit it.