Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Address.country_name_to_code(name: 'united_states') #1466

Merged
merged 3 commits into from
Nov 9, 2018
Merged

Add Faker::Address.country_name_to_code(name: 'united_states') #1466

merged 3 commits into from
Nov 9, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Nov 9, 2018

Checklist

  • Add Faker::Address.country_name_to_code(name: 'united_states')
  • Add tests and update docs
  • Change Faker::Address.country(code: nil) to Faker::Address.country_by_code(code: 'US')

@vbrazo vbrazo self-assigned this Nov 9, 2018
@vbrazo vbrazo merged commit 8047aad into faker-ruby:master Nov 9, 2018
@vbrazo vbrazo deleted the features/add-country-name-to-code branch November 9, 2018 01:25
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Add Faker::Address.country_name_to_code(name: 'united_states') (faker…
ccff4ff 
…-ruby#1466)

* Add country_name to code - Faker::Address

* Update CHANGELOG.md

* Fix address locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbrazo vbrazo

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vbrazo