Add Faker::JapaneseMedia namespace #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that this PR has an ID, I'll add a deprecation link to the |
vbrazo
approved these changes
Oct 19, 2018
|
No further changes planned, good to merge! |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Create Faker::JapaneseMedia namespace * Deprecate top-level JapaneseMedia methods * Update individual documentation for JapaneseMedia * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes what was previously:
The name
JapaneseMediawas chosen as it's a good catch-all for those who come from anime or manga backgrounds primarily – it's something common both can use to find these fakers. TechnicallyMangawould be the most correct as anime normally gets adapted from manga first, but this made more sense IMO.It opens up scope for future fakers based on other mainstream Japanese media such as My Hero Academia and One Punch Man.
As a side note, I'd say
Faker::Pokemonshould come underGameswhen moved in future.This PR is related to this issue #1318.