Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Games::HeroesOfTheStorm #1399

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Conversation

illsism
Copy link
Contributor

@illsism illsism commented Oct 11, 2018

Adds
Faker::Games::HeroesOfTheStorm.battleground
Faker::Games::HeroesOfTheStorm.class
Faker::Games::HeroesOfTheStorm.hero
Faker::Games::HeroesOfTheStorm.quote

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍 Overall looks good.

Could you wrap this module in Faker::Games::HeroesOfTheStorm?

README.md Outdated
@@ -92,6 +92,7 @@ Contents
- [Faker::GreekPhilosophers](doc/greek_philosophers.md)
- [Faker::Hacker](doc/hacker.md)
- [Faker::HarryPotter](doc/harry_potter.md)
- [Faker::HarryPotter](doc/heroes_of_the_storm.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be HeroesOfTheStorm.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@vbrazo vbrazo merged commit 95895f9 into faker-ruby:master Oct 11, 2018
@vbrazo vbrazo changed the title Add Faker::HeroesOfTheStorm Add Faker::Games::HeroesOfTheStorm Oct 11, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add Faker::HeroesOfTheStorm

* Add hots to games module

* Update heroes_of_the_storm.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants