Load faker I18n using custom backend chaining #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used `I18n.load_path` manipulation to load Faker translations, assuming that the `I18n.backend` was an implementation of `I18n::Backend::Simple`, or something similarly compatible with `load_path` and `#initialized?`. If the user of the library configured a different backend prior to loading Faker, this could result in a few possible adverse outcomes: * Faker resources are not _actually_ loaded, leaving Faker unable to render those items, or * As in the case of faker-ruby#1078, a NoMethodError on `#initialized?` The new implementation creates a custom backend just for faker, `Faker::I18nBackend`. This backend is exactly like the Simple backend, except that it loads resources only from Faker's locales folder, ignoring `I18n.load_path`. An instance of this backend is then chained together with the existing `I18n.backend` using `I18n::Backend::Chain`. This makes Faker's behavior less intrusive overall, and eliminates the need for an explicit reload. Fixes faker-ruby#1078.
Merged
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Load faker I18n using custom backend chaining The previous implementation used `I18n.load_path` manipulation to load Faker translations, assuming that the `I18n.backend` was an implementation of `I18n::Backend::Simple`, or something similarly compatible with `load_path` and `#initialized?`. If the user of the library configured a different backend prior to loading Faker, this could result in a few possible adverse outcomes: * Faker resources are not _actually_ loaded, leaving Faker unable to render those items, or * As in the case of faker-ruby#1078, a NoMethodError on `#initialized?` The new implementation creates a custom backend just for faker, `Faker::I18nBackend`. This backend is exactly like the Simple backend, except that it loads resources only from Faker's locales folder, ignoring `I18n.load_path`. An instance of this backend is then chained together with the existing `I18n.backend` using `I18n::Backend::Chain`. This makes Faker's behavior less intrusive overall, and eliminates the need for an explicit reload. Fixes faker-ruby#1078. * Minor changes * Update CHANGELOG.md
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Rollback i18n PR * Require helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
I18n.load_pathmanipulation toload Faker translations, assuming that the
I18n.backendwas animplementation of
I18n::Backend::Simple, or something similarlycompatible with
load_pathand#initialized?. If the user ofthe library configured a different backend prior to loading Faker,
this could result in a few possible adverse outcomes:
to render those items, or
#initialized?#1078, a NoMethodError on#initialized?The new implementation creates a custom backend just for faker,
Faker::I18nBackend. This backend is exactly like the Simplebackend, except that it loads resources only from Faker's locales
folder, ignoring
I18n.load_path. An instance of this backend isthen chained together with the existing
I18n.backendusingI18n::Backend::Chain. This makes Faker's behavior less intrusiveoverall, and eliminates the need for an explicit reload.
Fixes #1078.