Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some competitions were in the coaches array #1281

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Some competitions were in the coaches array #1281

merged 2 commits into from
Jun 13, 2018

Conversation

Eusebiotrigo
Copy link
Contributor

@Eusebiotrigo Eusebiotrigo commented Jun 13, 2018 •
edited by vbrazo
Loading

  • Update Faker::Football.competition and Faker::Football.coach locales

vbrazo
vbrazo approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 31ef196 into faker-ruby:master Jun 13, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:30
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@Eusebiotrigo @vbrazo
Some competitions were in the coaches array (faker-ruby#1281)
99f3987 
* Some competitions were in the coaches array

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@Eusebiotrigo Eusebiotrigo

Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eusebiotrigo @vbrazo