House appliances #1250
Merged
House appliances #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
May 26, 2018
vbrazo
reviewed
May 26, 2018
There was a problem hiding this comment.
Overall looks good. Thanks for contributing and welcome to the contributors' team. Your PR has what we expect: locales, documentation, a new module and tests. You also updated the changelog. Awesome! What other methods do you think we could add to this new API?
|
I tested locally and it seems to be pretty good 👍 |
|
Thank you for the feedback! |
|
Cool. Feel free to open a new issue when you have a new idea/suggestion 👍 |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add appliances faker data * Update CHANGELOG.md file * Update README.md file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
ApplianceAPI and its methods:Faker::Appliance.brandFaker::Appliance.equipment