-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faker::Markdown.sandwich #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase with master and fix the Rubocop
violations?
Could you also add your name + PR to the changelog.md
?
a359def
to
a5d7731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing 🥇
Overall the PR was ok. I had free time today and pushed a few small changes. Thanks again.
When will it be released? I'd love to use this! |
You could point to our master branch and use it until we release a new version. Only the owner could release the 1.8.8, so I'm sure when it'll happen. |
@krsnachandra we released a new version this month. |
* corrected typo on dune.md * get rid of ahead of myself dune.md changes * add documentation and extended sandwich artistry * tests pass ready to party * remove dune.md changes on my machine * Update changelog * Add missing sandwich tests
Another take on issue 1052... this creates a fake markdown text block starting with a header and then a variable number of sentences in a lorem ipsum paragraph and then a random markdown element. Users can repeat that duo of lorem paragraph and random markdown element if they want longer text blocks.
Since I am recycling other methods, I wasn't totally sure what to test for here other than the iteration on a default case had the right number of pieces.