Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more quotes to the silicon valley yml file to provide more variety #1060

Merged

Conversation

danielwheeler1987
Copy link

This PR adds a couple more quotes from silicon valley characters to provide a little more variety.

Copy link

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could definitely benefit with a few quotes added, good choice as well and I've checked them against the canon. What do you think, @stympy ?

@danielwheeler1987
Copy link
Author

Hey @Schwad thanks for taking a look.

@Schwad
Copy link

Schwad commented Nov 16, 2017

@danielwheeler1987 no worries. I get random automatic notifications for issues and PRs on repos I subscribe to via Code Triage built by @schneems and this is one of the repos I subscribe to! :)

@stympy stympy merged commit a3d2231 into faker-ruby:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants