Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stretchr/testify
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.5
Choose a base ref
...
head repository: stretchr/testify
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.0
Choose a head ref
  • 4 commits
  • 8 files changed
  • 5 contributors

Commits on Jun 28, 2022

  1. Add WithinTimeRange method (#1188)

    * Add WithinTimeRange method
    
    * Run ./.ci.generate.sh
    
    * Rename WithinTimeRange to WithinRange
    
    * Rename WithinRange expected parameter to actual
    
    * Capitalise start parameter at start of error message
    
    * Improve WithinRange example
    moolmanruan authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    2fab6df View commit details
    Browse the repository at this point in the history
  2. fix: assert.MapSubset (or just support maps in assert.Subset) (#1178)

    * WIP: added map key value check in subset
    
    * upgraded subset & notsubset to check handle maps
    OladapoAjala authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    66eef0e View commit details
    Browse the repository at this point in the history
  3. Allow mock expectations to be ordered (#1106)

    * Allow mock expectations to be ordered
    
    * Only say another call if it has been called before
    brackendawson authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    cf1284f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. impr: CallerInfo should print full paths to the terminal (#1201)

    * impr: `CallerInfo` should print full paths to the terminal
    
    I am proposing this simple change, which changes this output
    ```
    --- FAIL: TestABC (0.00s)
        --- FAIL: TestABC/C (0.00s)
            /this/is/a/path/to/file_test.go:258:
                	Error Trace:	file_test.go:258
                	            				file_test.go:748
                	Error:      	Not equal:
    ...
    ```
    to this:
    ```
    --- FAIL: TestABC (0.00s)
        --- FAIL: TestABC/C (0.00s)
            /this/is/a/path/to/file_test.go:258:
                	Error Trace:	/this/is/a/path/to/file_test.go:258
                	            				/this/is/a/path/to/file_test.go:748
                	Error:      	Not equal:
    ...
    ```
    
    With the latter output, it is much more straightforward to find the file
    you are looking for, even though in the displayed case, the file is the same.
    
    However, for VSCodium, the case is a little more helpful, since VSCodium's
    terminal is smart enough to recognize the output, and make links out of that input.
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    
    * test: fix the tests that depended on the previous behavior
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    
    Co-authored-by: Stavros Ntentos <[email protected]>
    stdedos and Stavros Ntentos authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    181cea6 View commit details
    Browse the repository at this point in the history
Loading