Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support cspell.config.js and remove support for cspell.js #895

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Jan 27, 2021

Supported list of configuration files:

Primary configuration file names:

  • cspell.config.js
  • cspell.config.cjs
  • cspell.config.json
  • cspell.config.yaml
  • cspell.config.yml
  • cspell.yaml
  • cspell.yml
  • .cspell.json
  • cspell.json

Alternate locations: might be removed in the future.

  • .cSpell.json
  • cSpell.json
  • .vscode/cspell.json
  • .vscode/cSpell.json
  • .vscode/.cspell.json

Note: Missing from the list is cspell.js and package.json.

  • cspell.js - causes issues with npx cspell when run from the same directory as a cspell.js config file. See Issues with using cspell.js config files. #891
  • package.json - No need to add support for a cspell section of a package.json file until there is a compelling reason to add it there.

@Jason3S Jason3S linked an issue Jan 27, 2021 that may be closed by this pull request
@Jason3S Jason3S merged commit 6fbb4b2 into master Jan 27, 2021
@Jason3S Jason3S deleted the dev branch January 27, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with using cspell.js config files.
1 participant