Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display of collectible images from Status Go #18657

Closed
Tracked by #19466
VolodLytvynenko opened this issue Jan 29, 2024 · 5 comments
Closed
Tracked by #19466

Incorrect display of collectible images from Status Go #18657

VolodLytvynenko opened this issue Jan 29, 2024 · 5 comments
Labels
bug medium-prio wallet: Collectibles all issues for the collectibles page of the wallet

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Jan 29, 2024

Reference to #18577 (comment)

Steps:

  1. Add as watch only the following account 0xcf2272205cc0cf96Cfbb9Dd740BD681D1E86901E (Note: Sometimes, collectibles may not be displayed immediately after initial account recovery. It is recommended to wait at least one minute after recovering and reloggin)
  2. Open current watch-only account -> check collectibles tab

Actual result:

Images of collections are shown instead of the expected collectible images.

actualcollectible.mp4

Expected result:

The images of collectibles should be displayed. The actual images of collectibles for the user can be found here https://opensea.io/chuqa/collected

ENV:

Nightly [29 Jan 2024]

@VolodLytvynenko VolodLytvynenko changed the title The collection images are not returned from Status go instead of image of collectible Incorrect display of collectible images from Status Go Jan 29, 2024
@mmilad75 mmilad75 self-assigned this Jan 29, 2024
@ulisesmac ulisesmac assigned ulisesmac and unassigned mmilad75 Feb 7, 2024
@ulisesmac ulisesmac removed the blocked label Mar 4, 2024
@ulisesmac ulisesmac assigned ulisesmac and unassigned ulisesmac Mar 4, 2024
@ulisesmac
Copy link
Contributor

Waiting for:

#19086 (Collectibles' new component implementation)

to get solved

@VolodLytvynenko
Copy link
Contributor Author

Hi @ulisesmac, it seems that the issue #19086 has been resolved, and the current problem is no longer blocked. I have removed the 'blocked' label. Please feel free to add it back (block lablel) if there are other circumstances still preventing this PR from progressing

@ulisesmac
Copy link
Contributor

@VolodLytvynenko thanks, yeah, it's ready to be taken.

But I believe this should be part of the issue that incorportates the new collectible component to the listing, since this one is very small.

If I recall correctly, @mmilad75 is working on it

@J-Son89 or maybe no one is working on it?

@VolodLytvynenko VolodLytvynenko added wallet: Collectibles all issues for the collectibles page of the wallet medium-prio labels Apr 26, 2024
@J-Son89
Copy link
Contributor

J-Son89 commented May 13, 2024

@ulisesmac - we have that component added now. Not sure what needs to be done here? 🤔

@ulisesmac
Copy link
Contributor

@J-Son89 Nothing else, we can close this issue.

@ulisesmac ulisesmac removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug medium-prio wallet: Collectibles all issues for the collectibles page of the wallet
Development

No branches or pull requests

4 participants