Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Uniswap: personal_sign doesn't support 'type':'uint160' in JSON #15193

Closed
daferna opened this issue Feb 25, 2023 · 3 comments
Closed

Comments

@daferna
Copy link
Contributor

daferna commented Feb 25, 2023

Bug Report

Problem

Currently users can't use uniswap to trade ERC-20 tokens. Users must personal_sign a JSON message to trade, but the wallet is attempting & failing to parse the JSON. Might be an issue with status-go, or the frontend, or a combination of the two.

Screen recording here:
https://drive.google.com/file/d/1jUpNrIgVffzKIPQrSH7KiJAUWHMLv1vp/view?usp=share_link

Reproduction

  1. Open Status
  2. Approve an ERC-20 to swap on Uniswap
  3. Try and personal_sign the JSON swap approval

Additional Information

  • Status version: release 1.20.3
  • Operating System: Android
@daferna daferna added the bug label Feb 25, 2023
@daferna
Copy link
Contributor Author

daferna commented Feb 26, 2023

This is more of an issue with status-go which uses the go-ethereum apitypes library at: https://github.com/ethereum/go-ethereum/blob/master/signer/core/apitypes/types.go

The error is being thrown on the equivalent of line 691 in a older version of the types.go file: https://github.com/ethereum/go-ethereum/blob/619a3e70858e60240ce1df75bdf65ba748387e57/signer/core/apitypes/types.go#L691

Users have submitted pull requests to go-ethereum in the past to add types in the past for this exact same EIP-712 issue, either Uniswap needs to conform to go-ethereum or vice versa: ethereum/go-ethereum#17696

@daferna
Copy link
Contributor Author

daferna commented Feb 27, 2023

I've submitted a PR in go-ethereum that should fix the issue: ethereum/go-ethereum#26770

@daferna
Copy link
Contributor Author

daferna commented Mar 8, 2023

Should be fixed by the PR ethereum/go-ethereum#26770

@daferna daferna closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant